mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-838) Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
Date Wed, 01 Aug 2018 18:44:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565804#comment-16565804

Bryan Turner commented on SSHD-838:

My thanks and sincere appreciation, [~lgoldstein].

Perhaps a possible solution is to define some "events" that can be signalled via a ConnectionEventListener
before the session is established and let the user decide how to log them - e.g., connection
requested, connection established, connection accepted, connection terminated + reason (OK
or exception), etc.... For backward compatibility, if no event listener is registered then
the code will just log the event as it currently does (i.e., WARNING + stack trace)...

Once the session is established, all events associated with it should be signalled via the
SessionListener. In this context, please see if there are other such exceptions/warnings that
are signalled via logging and could potentially be signalled via either the ConnectionEventListener
or the SessionListener.

The approach itself sounds good to me. Bitbucket Server is already implementing its own {{SessionListener}},
so implementing a {{ConnectionListener}} (or whatever name is used) would be a logical enhancement,
and allow us to customize the behavior to fit our needs. That said, though, I want to be respectful
of your time, because I'm not sure I personally have the time to devote to _building_ that
change, and [~jpalacios] is about to leave on vacation, and I don't want to assume you have
the time to build it either.

Best regards,
Bryan Turner

> Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
> ------------------------------------------------------------------------
>                 Key: SSHD-838
>                 URL: https://issues.apache.org/jira/browse/SSHD-838
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: jpalacios
>            Priority: Minor
>         Attachments: sshd-nio-acceptor-logging.patch
> As discussed in [SSHD-833|https://issues.apache.org/jira/browse/SSHD-833], it appears
that when a client disconnects before the handshake completes there's some pretty loud logging
coming from the {{Nio2Acceptor.AcceptCompletionHandler#okToReaccept}}.
> The entire message is logged at {{WARN}} level. Also, several lines from the stack trace
are logged individually at the same level.
> We feel this much logging at {{WARN}} level will be too much noise for system administrators
who might think there's something wrong with the system. We propose:
> # Changing the log level to {{DEBUG}} / {{FINE}} 
> # Logging the stacktrace in a single message

This message was sent by Atlassian JIRA

View raw message