mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-838) Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
Date Wed, 08 Aug 2018 14:06:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573267#comment-16573267
] 

Bryan Turner commented on SSHD-838:
-----------------------------------

[~lgoldstein],

Thanks for such rapid turnaround! The new interface looks great. Since it's new functionality,
will you be releasing it as 2.1.0? Seems a little odd for a patch release to introduce a new
public SPI. Any thoughts on when a release will be cut with it?

Once this change is released, I'll get Bitbucket Server upgraded. At that point, I think we'll
make SSHD's own NIO factory our default, instead of Mina. We've been holding off due to these
warnings coming from our production server where we've been testing the changeover.

Best regards, and thanks again for all your support!
Bryan Turner

> Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
> ------------------------------------------------------------------------
>
>                 Key: SSHD-838
>                 URL: https://issues.apache.org/jira/browse/SSHD-838
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: jpalacios
>            Assignee: Goldstein Lyor
>            Priority: Major
>              Labels: important, listener, logging
>             Fix For: 2.0.1
>
>         Attachments: sshd-nio-acceptor-logging.patch
>
>
> As discussed in [SSHD-833|https://issues.apache.org/jira/browse/SSHD-833], it appears
that when a client disconnects before the handshake completes there's some pretty loud logging
coming from the {{Nio2Acceptor.AcceptCompletionHandler#okToReaccept}}.
> The entire message is logged at {{WARN}} level. Also, several lines from the stack trace
are logged individually at the same level.
> We feel this much logging at {{WARN}} level will be too much noise for system administrators
who might think there's something wrong with the system. We propose:
> # Changing the log level to {{DEBUG}} / {{FINE}} 
> # Logging the stacktrace in a single message



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message