mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Goldstein Lyor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-840) Unknown commands cause IllegalStateException instead of being correctly handled
Date Sat, 11 Aug 2018 08:12:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577097#comment-16577097

Goldstein Lyor commented on SSHD-840:

[~nite] thanks for the patch  - merged in [with acknowledgement|https://github.com/apache/mina-sshd/commit/4c12a21977714ab8d3f454d52c43be93a773f50f]
- please close the PR. As far as backporting it to previous versions, we don't really do that
since it is too much of an overhead to manage more than one release. Of course you can always
fetch the relevant code according to its GIT tag, patch it and create a new version just for
you (not ideal, I admit, but best solution I can think of for now). As far as 0.14.1 is concerned
I doubt even more we will back-patch it since it is so old.

> Unknown commands cause IllegalStateException instead of being correctly handled
> -------------------------------------------------------------------------------
>                 Key: SSHD-840
>                 URL: https://issues.apache.org/jira/browse/SSHD-840
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 0.14.0, 1.6.0, 2.0.0
>            Reporter: Robert Varga
>            Priority: Major
>             Fix For: 2.0.1
> As [https://github.com/CESNET/libnetconf2/issues/68] shows, MINA SSHD has a different
behavior than OpenSSH when faced unknowns – in this case coming from a buggy server.
> While OpenSSH was able to establish a session, OpenDaylight (using SSHD 1.6.0) was not
– throwing an IllegalStateException.
> Rather than throwing an exception, send an SSH_MSG_UNIMPLEMENTED as specified by [https://tools.ietf.org/html/rfc4253#section-11.4]

This message was sent by Atlassian JIRA

View raw message