mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Goldstein Lyor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-708) Add support for password encrypted OpenSSH private key files
Date Wed, 12 Dec 2018 12:43:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718934#comment-16718934

Goldstein Lyor commented on SSHD-708:

OpenSSH doesn't limit this; any value in the range [1 .. INT_MAX] is allowed. IMO we shouldn't
worry about unreasonably large values here; this is reading a private key of a user. If the
user created that key with 2**30 rounds, so be it. The code should just guard against rounds
< 1.

This is where our philosophies differ - I believe I will make it configurable via a system
property (just in case) with a default of 2^16. Thanks for the feedback - I will make the
necessary changes and publish a PR for more feedback from you before merging so we can avoid
a back and forth on the issue.

> Add support for password encrypted OpenSSH private key files
> ------------------------------------------------------------
>                 Key: SSHD-708
>                 URL: https://issues.apache.org/jira/browse/SSHD-708
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Goldstein Lyor
>            Assignee: Goldstein Lyor
>            Priority: Minor
>             Fix For: 2.1.1
> The current code supports only reading un-encrypted private key files

This message was sent by Atlassian JIRA

View raw message