mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] thefourtheye commented on issue #87: clear response buffer with unsupported extension
Date Sat, 09 Feb 2019 08:12:49 GMT
thefourtheye commented on issue #87: clear response buffer with unsupported extension
URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462024304
 
 
   @lgoldstein Wouldn't this make the life of the developers a bit easier?
   
   1. They don't have worry about clearing the buffer everywhere. Less code repetition.
   2. If somebody forgets to call `send*` functions without clearing the buffer, it would
break. We have to rely only on the code review process to find this.
   
   Those refactoring commits are just to make sure that we don't end up with a problem like
this again. I am fine with or without it.
   
   ---
   
   PS. I went looking for the expansion of LSRP. Couldn't find a satisfactory one. Now I am
curious 😜 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message