mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] lgoldstein commented on issue #87: clear response buffer with unsupported extension
Date Sat, 09 Feb 2019 08:34:33 GMT
lgoldstein commented on issue #87: clear response buffer with unsupported extension
URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462025659
 
 
   LSRP - Least Single Responsibility Principle.
   
   >> Wouldn't this make the life of the developers a bit easier?
   
   I don't think so - my concern is not code repetition but rather unexpected code behavior
- whoever invokes `sendStatus` provides a buffer that may or may not be already initialized
somehow - for whatever purpose (maybe some custom feature). I would rather `sendStatus` not
tinker with the input buffer beyond appending the status message parameters.
   
   Anyway, I have made a few minor changes to your code (many thanks) - you can see them [here](https://github.com/lgoldstein/mina-sshd/commit/5f49088fb7abf464ee8b2b521235340a10b70ec3).
They will be merged into the _master_ version once we release 2.2.0 (which unfortunately means
the fix will have to wait until we release the next version)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message