mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (SSHD-893) SCP download with pattern does not work download with virtual filesystem
Date Tue, 12 Feb 2019 08:13:00 GMT

     [ https://issues.apache.org/jira/browse/SSHD-893?focusedWorklogId=197427&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197427
]

ASF GitHub Bot logged work on SSHD-893:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Feb/19 08:12
            Start Date: 12/Feb/19 08:12
    Worklog Time Spent: 10m 
      Work Description: lgoldstein commented on pull request #89: [SSHD-893] Fix SCP download
with pattern issue in rooted filesystem
URL: https://github.com/apache/mina-sshd/pull/89#discussion_r255840920
 
 

 ##########
 File path: sshd-common/src/main/java/org/apache/sshd/common/util/io/DirectoryScanner.java
 ##########
 @@ -115,49 +126,37 @@
  * @author <a href="mailto:levylambert@tiscali-dsl.de">Antoine Levy-Lambert</a>
  */
 public class DirectoryScanner {
-
     /**
      * The base directory to be scanned.
      */
-    protected File basedir;
+    private Path basedir;
 
     /**
      * The patterns for the files to be included.
      */
-    protected String[] includes;
-
-    /**
-     * The files which matched at least one include and no excludes
-     * and were selected.
-     */
-    protected List<String> filesIncluded;
+    private List<String> includePatterns;
 
     /**
-     * Whether or not the file system should be treated as a case sensitive
-     * one.
+     * Whether or not the file system should be treated as
+     * a case sensitive one.
      */
-    protected boolean isCaseSensitive = true;
+    private boolean caseSensitive = OsUtils.isUNIX();
 
 Review comment:
   I mean override `ScpFileOpener` and implement `ScpFileOpener#getMatchingFilesToSend` using
a `DirectoryScanner` with some other case-sensitivity (NOTE: `DirectoryScanner#setCaseSensitivity`
is available to override the default). This can be easily done when initializing the SCP client/server
by setting a default `ScpFileOpener` when they are configured - thus no need to override the
opener on each session.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 197427)
    Time Spent: 1h 40m  (was: 1.5h)

> SCP download with pattern does not work download with virtual filesystem
> ------------------------------------------------------------------------
>
>                 Key: SSHD-893
>                 URL: https://issues.apache.org/jira/browse/SSHD-893
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Subramaniajeeva
>            Assignee: Goldstein Lyor
>            Priority: Minor
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Right now, download with pattern doesn't work when the underlying
> filesystem is virtual filesystem. Also, current tests were masking the
> behaviour by providing working location as rooted filesystem path.
> Handled the same with PR: https://github.com/apache/mina-sshd/pull/88



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message