mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Goldstein Lyor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-907) Clearing user defined attributes in preclose is creating inconsistent behaviour
Date Sun, 17 Mar 2019 17:19:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794542#comment-16794542
] 

Goldstein Lyor commented on SSHD-907:
-------------------------------------

Please note that (at least according to the code) the session attributes are cleared when
{{preClose}} is called on the session. I don't see how what you describe can happen since
{{SftpEventListeber#closed}} is called while the session is still active. I will try and see
if I can find some flow that can cause what you describe but meanwhile I would like to suggest
that you review your code where you set the custom attributes and make sure the inconsistency
is not due to that code. Also, try opening some log levels and see if you can provide some
insight as to how/when the attributes are cleared unexpectedly.

> Clearing user defined attributes in preclose is creating inconsistent behaviour
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-907
>                 URL: https://issues.apache.org/jira/browse/SSHD-907
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.3.0
>            Reporter: Subramaniajeeva
>            Assignee: Goldstein Lyor
>            Priority: Major
>
> As a part of [https://github.com/apache/mina-sshd/commit/f5d036ddd3de3521fb9f83253e30eab67bdbbcb3],
the user defined attributes are getting cleared from session.
> This is creating inconsistent behaviour in `SftpEventListener` closed(). The attributes
are being vanished intermittently and the vanishing part is not consistent.
>  
> Is there any race condition which is not being handled properly?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message