mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mina-sshd] tomaswolf commented on a change in pull request #105: SSHD-930 Send the client version string after receiving the version string of the server
Date Wed, 10 Jul 2019 21:20:28 GMT
tomaswolf commented on a change in pull request #105: SSHD-930 Send the client version string
after receiving the version string of the server
URL: https://github.com/apache/mina-sshd/pull/105#discussion_r302277221
 
 

 ##########
 File path: sshd-core/src/main/java/org/apache/sshd/client/session/ClientSessionImpl.java
 ##########
 @@ -90,16 +88,9 @@ public ClientSessionImpl(ClientFactoryManager client, IoSession ioSession)
throw
         authFuture.setAuthed(false);
 
         signalSessionCreated(ioSession);
-        sendClientIdentification();
 
-        KexExtensionHandler extHandler = getKexExtensionHandler();
-        if ((extHandler == null) || (!extHandler.isKexExtensionsAvailable(this, AvailabilityPhase.PREKEX)))
{
-            kexState.set(KexState.INIT);
-            sendKexInit();
-        } else {
-            if (log.isDebugEnabled()) {
-                log.debug("<init>({}) delay KEX-INIT until server-side one received",
this);
-            }
+        if (sendImmediateIdentification) {
+            initializeKexPhase();
 
 Review comment:
   I don't think this is OK. This will make it impossible to implement any client-side proxy
protocol to connect through SOCKS or HTTP CONNECT proxies if `!sendImmediateIdentification`.
If sending the client identification is delayed, the proxy protocol must still be started
before expecting an answer from the server.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message