mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lyor Goldstein (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-953) ProcessShellCommandFactory does not parse quoted arguments correctly
Date Sat, 02 Nov 2019 09:21:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965287#comment-16965287
] 

Lyor Goldstein commented on SSHD-953:
-------------------------------------

{quote}
Our client software already uses

https://github.com/hierynomus/sshj
. I was trying to build an integration test with MINA SSHD as a temporary SSH server for the
test and came across this issue. I have worked around it by implementing my own ShellFactory,
as you suggested.
{quote}
Then perhaps you can consider using MINA SSHD for client side as well... :)

> ProcessShellCommandFactory does not parse quoted arguments correctly
> --------------------------------------------------------------------
>
>                 Key: SSHD-953
>                 URL: https://issues.apache.org/jira/browse/SSHD-953
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 2.3.0
>            Reporter: Niklas Rosenstein
>            Assignee: Lyor Goldstein
>            Priority: Minor
>
> {code:java}
> sshServer.setCommandFactory(new ProcessShellCommandFactory();
> {code}
> This command factory does not parse quoted arguments correctly. Example:
> {code}
> "scp -t -r -p '/Volumes/data/input.csv'"
> {code}
> The last argument is parsed as
> {code}
> "'/Volumes/git/data/input.csv'"
> {code}
> when it should be parsed as
> {code}
> "/Volumes/git/data/input.csv"
> {code}
> (note the missing single quotes)
> The implementation of the parsing uses {{GenericUtils.split()}} rather than a function
that handles quotes correctly.
> {code}
>         ShellFactory factory = new ProcessShellFactory(GenericUtils.split(command, '
'));
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message