mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lyor Goldstein (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-956) Change the authTimeout and idleTimeout from System clock based to Hardware clock based
Date Tue, 26 Nov 2019 17:44:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982711#comment-16982711
] 

Lyor Goldstein commented on SSHD-956:
-------------------------------------

A good point, though (IMO) minor since
{quote}
randomly fire when the system time is changed
{quote}
system time changes are (usually) rare, and the described issue would require some combination
of other conditions to occur - thus very rare bug.

That being said, I will look into the suggested change as we do care only about *difference*
in time and not absolute values.

> Change the authTimeout and idleTimeout from System clock based to Hardware clock based
> --------------------------------------------------------------------------------------
>
>                 Key: SSHD-956
>                 URL: https://issues.apache.org/jira/browse/SSHD-956
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 2.1.0, 2.3.0
>            Reporter: Chetan Narsude
>            Assignee: Lyor Goldstein
>            Priority: Minor
>
> {{Because the timeout calculations are done based on System.currentTimeInMillis(), they
are susceptible to change in the system clock and randomly fire when the system time is changed.}}
>  
> {{If these timeouts are based on the hardware clock (System.nanoTime()), they will be
shielded from ad hoc changes to the system time.}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message