mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roberto Deandrea (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-964) SSH_MSG_CHANNEL_EOF never sent or received for local and remote port forwarding
Date Tue, 21 Jan 2020 09:13:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020059#comment-17020059
] 

Roberto Deandrea commented on SSHD-964:
---------------------------------------

Hi Lyor,

For local and remote port forwarding tunnels when sendEof() is executed, isClosing() is always
true because the channel is not in Opened state and the SSH_MSG_CHANNEL_EOF is never sent.

 _protected void sendEof() throws IOException {_
   _if (isClosing()) {_
     _if (log.isDebugEnabled()) {_
     _log.debug("sendEof({}) already closing or closed", this);_
   _}_
   _return;_
 _}_

...........................................................................


 _public final boolean isClosing() {_
   _return state.get() != State.Opened;_
 _}_

 

When a SSH_MSG_CHANNEL_EOF is received In TcpipClientChannel.handleEof() serverSession.shudownOutputStream()
causes the socket between SSH client and SSH server to be closed, and this is not the rigth
behaviour.

 _@Override_
 _public void handleEof() throws IOException {_
   _super.handleEof();_
   _serverSession.shudownOutputStream();_
 _}_

 

I hope this can clarify this issue.

 

Kind Regards

Roberto

 

> SSH_MSG_CHANNEL_EOF never sent or received for local and remote port forwarding
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-964
>                 URL: https://issues.apache.org/jira/browse/SSHD-964
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.3.0, 2.3.1
>            Reporter: Roberto Deandrea
>            Assignee: Lyor Goldstein
>            Priority: Major
>
> We found that the message SSH_MSG_CHANNEL_EOF is never sent or received for local and
remote port forwarding connections.
> We found probably the issue and we changed the code locally in a couple of java classes
to fix this issue.
> Let me know if we can commit our changes in a pull request (into a specific Apache SSHD
branch) so that you can peer review the changes  and decide if you can accept them...
>  
> Kind Regards
> Roberto Deandrea
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message