mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lyor Goldstein (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-964) SSH_MSG_CHANNEL_EOF never sent or received for local and remote port forwarding
Date Thu, 23 Jan 2020 17:50:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022311#comment-17022311
] 

Lyor Goldstein commented on SSHD-964:
-------------------------------------

{quote}
I will try your suggested code changes into AbstractChannel class in methods sendEof() and
writePacket() 
{quote}
Thanks [~roberto.deandrea]. On that note, I am having 2nd thoughts about this piece of code:
{code:java|title=AbstractChannel#sendEof}
if (eofReceived.get()) {
    return;
}
{code}
I am not sure why this is correct... I have re-read the relevant section in RFC4254 and I
cannot really find an interpretation that mandates this behavior. What was the rationale behind
it when you made your changes ?

{quote}
NOT REMOVING shutdownOutputStream() method in TcpipClientChannel class IS NOT ACCEPTABLE
{quote}
Like I said, I am not against removing it - but I need some more time to weigh the consequences...

> SSH_MSG_CHANNEL_EOF never sent or received for local and remote port forwarding
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-964
>                 URL: https://issues.apache.org/jira/browse/SSHD-964
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.3.0, 2.3.1
>            Reporter: Roberto Deandrea
>            Assignee: Lyor Goldstein
>            Priority: Major
>
> We found that the message SSH_MSG_CHANNEL_EOF is never sent or received for local and
remote port forwarding connections.
> We found probably the issue and we changed the code locally in a couple of java classes
to fix this issue.
> Let me know if we can commit our changes in a pull request (into a specific Apache SSHD
branch) so that you can peer review the changes  and decide if you can accept them...
>  
> Kind Regards
> Roberto Deandrea
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message