mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roberto Deandrea (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-964) SSH_MSG_CHANNEL_EOF never sent or received for local and remote port forwarding
Date Fri, 24 Jan 2020 08:26:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022761#comment-17022761
] 

Roberto Deandrea commented on SSHD-964:
---------------------------------------

Hi Lyor,

>>I am not sure why this is correct... I have re-read the relevant section in RFC4254
and I cannot really find an interpretation that mandates this behavior. What was the >>rationale
behind it when you made your changes ?

The rationale is that the SSH_MSG_CHANNEL_EOF message is not ackknoledged according to the
standard.

 

>>Like I said, I am not against removing it - but I need some more time to weigh the
consequences... I was able to trace its introduction to SSHD-902 - I would appreciate it >>if
you could also take a look at it and give me your opinion on it.

I think it's wrong shutdownOutputStream() when a client channel receives an EOF from the other
side of the connection, because in this case the socket connection is always closed and I
think it's not the right behavior. Maybe shutdownOutputStream() is to be performed later when
the channel is being closed.

 

Kind Regards

Roberto.

> SSH_MSG_CHANNEL_EOF never sent or received for local and remote port forwarding
> -------------------------------------------------------------------------------
>
>                 Key: SSHD-964
>                 URL: https://issues.apache.org/jira/browse/SSHD-964
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.3.0, 2.3.1
>            Reporter: Roberto Deandrea
>            Assignee: Lyor Goldstein
>            Priority: Major
>
> We found that the message SSH_MSG_CHANNEL_EOF is never sent or received for local and
remote port forwarding connections.
> We found probably the issue and we changed the code locally in a couple of java classes
to fix this issue.
> Let me know if we can commit our changes in a pull request (into a specific Apache SSHD
branch) so that you can peer review the changes  and decide if you can accept them...
>  
> Kind Regards
> Roberto Deandrea
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message