mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mina-sshd] lgoldstein commented on issue #111: [SSHD-967] fixed byte buffer issue
Date Fri, 21 Feb 2020 11:01:08 GMT
lgoldstein commented on issue #111: [SSHD-967] fixed byte buffer issue
URL: https://github.com/apache/mina-sshd/pull/111#issuecomment-589606253
 
 
   I would feel better if you could also add a unit test that checks specifically this issue
(shouldn't be too hard). First write the unit test and make sure it fails on the **unpatched**
code, then apply the patch and see that the test succeeds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message