From dev-return-35997-apmail-mina-dev-archive=mina.apache.org@mina.apache.org Thu Feb 27 08:15:11 2020 Return-Path: X-Original-To: apmail-mina-dev-archive@www.apache.org Delivered-To: apmail-mina-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 1F0611980A for ; Thu, 27 Feb 2020 08:15:11 +0000 (UTC) Received: (qmail 83871 invoked by uid 500); 27 Feb 2020 08:15:10 -0000 Delivered-To: apmail-mina-dev-archive@mina.apache.org Received: (qmail 83841 invoked by uid 500); 27 Feb 2020 08:15:10 -0000 Mailing-List: contact dev-help@mina.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@mina.apache.org Received: (qmail 83823 invoked by uid 99); 27 Feb 2020 08:15:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2020 08:15:10 +0000 From: GitBox To: dev@mina.apache.org Subject: [GitHub] [mina-sshd] lgoldstein commented on issue #112: SSHD-968 Message-ID: <158279131014.25531.11069066607168962437.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 27 Feb 2020 08:15:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lgoldstein commented on issue #112: SSHD-968 URL: https://github.com/apache/mina-sshd/pull/112#issuecomment-591840036 The suggested fix seems to involve too many methods changes - not mention the fact that the extra argument is very specific to this issue. What if future fixes require more argument ? However, your fix has given me an idea I would like to explore that may provide (IMO) a better solution. Be patient for 1-2 days and I might have something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org For additional commands, e-mail: dev-help@mina.apache.org