From dev-return-36083-apmail-mina-dev-archive=mina.apache.org@mina.apache.org Sun Mar 1 18:09:56 2020 Return-Path: X-Original-To: apmail-mina-dev-archive@www.apache.org Delivered-To: apmail-mina-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id BA8631903E for ; Sun, 1 Mar 2020 18:09:55 +0000 (UTC) Received: (qmail 91274 invoked by uid 500); 1 Mar 2020 18:09:49 -0000 Delivered-To: apmail-mina-dev-archive@mina.apache.org Received: (qmail 91160 invoked by uid 500); 1 Mar 2020 18:09:49 -0000 Mailing-List: contact dev-help@mina.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@mina.apache.org Received: (qmail 90776 invoked by uid 99); 1 Mar 2020 18:09:48 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Mar 2020 18:09:48 +0000 From: GitBox To: dev@mina.apache.org Subject: [GitHub] [mina-sshd] lgoldstein commented on a change in pull request #116: Add authorized_keys/verification support for OpenSSH "security key" key types Message-ID: <158308618855.27402.16398909665666705415.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 01 Mar 2020 18:09:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit lgoldstein commented on a change in pull request #116: Add authorized_keys/verification support for OpenSSH "security key" key types URL: https://github.com/apache/mina-sshd/pull/116#discussion_r386127536 ########## File path: sshd-common/src/main/java/org/apache/sshd/common/u2f/SkEcdsaPublicKey.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sshd.common.u2f; + +import java.security.interfaces.ECPublicKey; + +public class SkEcdsaPublicKey implements SecurityKeyPublicKey { + + private static final long serialVersionUID = -8758432826838775097L; + + private final String appName; + private final boolean noTouchRequired; + private final ECPublicKey delegatePublicKey; + + public SkEcdsaPublicKey(String appName, boolean noTouchRequired, ECPublicKey delegatePublicKey) { + this.appName = appName; + this.noTouchRequired = noTouchRequired; + this.delegatePublicKey = delegatePublicKey; + } + + @Override + public String getAlgorithm() { + return "SK-ECDSA"; Review comment: Please make this a public literal constant of this class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org For additional commands, e-mail: dev-help@mina.apache.org