From dev-return-36133-apmail-mina-dev-archive=mina.apache.org@mina.apache.org Wed Mar 25 09:23:02 2020 Return-Path: X-Original-To: apmail-mina-dev-archive@www.apache.org Delivered-To: apmail-mina-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 3FEB219A34 for ; Wed, 25 Mar 2020 09:23:02 +0000 (UTC) Received: (qmail 44955 invoked by uid 500); 25 Mar 2020 09:23:01 -0000 Delivered-To: apmail-mina-dev-archive@mina.apache.org Received: (qmail 44926 invoked by uid 500); 25 Mar 2020 09:23:01 -0000 Mailing-List: contact dev-help@mina.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@mina.apache.org Received: (qmail 44897 invoked by uid 99); 25 Mar 2020 09:23:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Mar 2020 09:23:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B1D71E2C44 for ; Wed, 25 Mar 2020 09:23:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 31A2278031D for ; Wed, 25 Mar 2020 09:23:00 +0000 (UTC) Date: Wed, 25 Mar 2020 09:23:00 +0000 (UTC) From: =?utf-8?Q?Emmanuel_L=C3=A9charny_=28Jira=29?= To: dev@mina.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DIRMINA-1079) MINA fails to connect from behind a proxy if endpoint is not resolved MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DIRMINA-1079?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D17= 066548#comment-17066548 ]=20 Emmanuel L=C3=A9charny commented on DIRMINA-1079: -------------------------------------------- I can cut a release later this week. Pretty busy atm with family circling a= round me plus day job. The new normal nowadays ;-) > MINA fails to connect from behind a proxy if endpoint is not resolved > --------------------------------------------------------------------- > > Key: DIRMINA-1079 > URL: https://issues.apache.org/jira/browse/DIRMINA-1079 > Project: MINA > Issue Type: Bug > Components: Handler > Affects Versions: 2.0.16 > Reporter: Anton Novikov > Assignee: Jonathan Valliere > Priority: Major > Fix For: 2.0.23 > > Attachments: DIRMINA-1079.patch > > > MINA fails to connect from behind a proxy if endpoint address is not reso= lved. This happens for both HTTP and SOCKS proxy and it seems that the reas= on for this are typos in HttpProxyRequest and SocksProxyRequest. The follow= ing changes seem to fix the issue: > HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved())= {}} with=C2=A0{{if (endpointAddress.isUnresolved()) {}} > SocksProxyRequest line 162: replace {{if (adr !=3D null && !adr.isUnresol= ved()) {}} with=C2=A0{{if (adr !=3D null && adr.isUnresolved()) {}} > Note the negation is gone in both cases -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org For additional commands, e-mail: dev-help@mina.apache.org