mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mina-sshd] gnodet commented on a change in pull request #137: [SSHD-1003] Use asynchronous streams when forwarding ports
Date Thu, 04 Jun 2020 08:18:12 GMT

gnodet commented on a change in pull request #137:
URL: https://github.com/apache/mina-sshd/pull/137#discussion_r435075028



##########
File path: sshd-core/src/main/java/org/apache/sshd/common/io/nio2/Nio2Session.java
##########
@@ -368,7 +368,6 @@ protected void handleReadCycleCompletion(
                     log.debug("handleReadCycleCompletion({}) Socket has been disconnected
(result={}), closing IoSession now",
                             this, result);
                 }
-                close(true);

Review comment:
       This suppression seems to remove a bunch of problems with the channel being closed
way too early.  The `-1` result indicates an EOF, but not an error, so closing the session
is wrong.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message