mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chetan Narsude (Jira)" <j...@apache.org>
Subject [jira] [Commented] (SSHD-1010) Removing meaningless usage of Byte.SIZE, Integer.SIZE and Long.SIZE
Date Thu, 04 Jun 2020 11:26:00 GMT

    [ https://issues.apache.org/jira/browse/SSHD-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125843#comment-17125843

Chetan Narsude commented on SSHD-1010:

could you point out all the instances where this is applicable?


I thought I saw just one more than the one I fixed. Fixing the other one had some tests fail
inexplicably and neither did I needed that fix nor I had knowledge/time/patience to understand
the tests to submit the fix for other instance.

> Removing meaningless usage of Byte.SIZE, Integer.SIZE and Long.SIZE
> -------------------------------------------------------------------
>                 Key: SSHD-1010
>                 URL: https://issues.apache.org/jira/browse/SSHD-1010
>             Project: MINA SSHD
>          Issue Type: Task
>            Reporter: Guillaume Nodet
>            Priority: Minor
> See https://github.com/apache/mina-sshd/commit/a029229309d88215a1f7fb6e3edb7fe4feff1385
> There are lots of usage of {{xxx.SIZE}} when they usually refer to {{xxx.BYTES}} in order
to reserve a number of bytes in a buffer, or to refer to a given value such as {{32}} which
isn't related to a number of bits.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org

View raw message