mina-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mina-sshd] chrjoedal commented on pull request #180: Added support for sftp client posix rename
Date Wed, 13 Jan 2021 14:12:28 GMT

chrjoedal commented on pull request #180:
URL: https://github.com/apache/mina-sshd/pull/180#issuecomment-759474220


   > > > @chrjoedal looks good. Is there any way you could add a test for the new
extension ?
   > > 
   > > 
   > > I have tried to give it a look.
   > > Problem is, that I have only created the client-side support of posix-rename
   > > I have not looked into enabling the support for posix-rename server-side.
   > > When I then try to make the unit-test for posix-rename, I get the exception:
   > > `java.lang.AssertionError: Extension not supported: posix-rename@openssh.com`
   > > It is therefore a bit hard to test, but I am open for suggestions, as this is
my first code change to mina-sshd, so there are many elements in the code, I have not covered.
   > > I have made the test with my local sftp server (for which I needed the feature),
where it works fine.
   > 
   > Ah, the best way would be to add the server-side too. I don't think it is much more
complicated than the server side, the only thing is that we'll need to actual _rename_ implementation,
but that should not be very difficult. Let me know if you need some help.
   
   I have never used the server part of this module - only the client path. So I do not think
I am the right for the job, as I have newer used it, started it, or even looked in the code.
   
   I just made this little extension to the client, and submitted it, so others could benefit
from it as well :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


Mime
View raw message