mrunit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MRUNIT-140) TestDriver should use composition and have less responsilibities
Date Mon, 12 Nov 2012 10:07:13 GMT

    [ https://issues.apache.org/jira/browse/MRUNIT-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495190#comment-13495190
] 

Hudson commented on MRUNIT-140:
-------------------------------

Integrated in mrunit-trunk #433 (See [https://builds.apache.org/job/mrunit-trunk/433/])
    MRUNIT-140: TestDriver should use composition and have less responsibilities (bdechoux)
(Revision a6e9d4d0c5715abafb24db4114a059707571bc29)

     Result = SUCCESS
dbeech : https://git-wip-us.apache.org/repos/asf?p=mrunit.git&a=commit&h=a6e9d4d0c5715abafb24db4114a059707571bc29
Files : 
* src/main/java/org/apache/hadoop/mrunit/internal/util/Errors.java
* src/main/java/org/apache/hadoop/mrunit/internal/util/StringUtils.java
* src/main/java/org/apache/hadoop/mrunit/TestDriver.java
* src/test/java/org/apache/hadoop/mrunit/internal/util/TestStringUtils.java
* src/test/java/org/apache/hadoop/mrunit/TestTestDriver.java
* src/test/java/org/apache/hadoop/mrunit/internal/util/TestErrors.java

                
> TestDriver should use composition and have less responsilibities
> ----------------------------------------------------------------
>
>                 Key: MRUNIT-140
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-140
>             Project: MRUnit
>          Issue Type: Task
>            Reporter: Bertrand Dechoux
>            Assignee: Bertrand Dechoux
>            Priority: Minor
>             Fix For: 1.0.0
>
>         Attachments: mrunit-counter-error-message.diff, mrunit-record-error.diff, mrunit-record-error.patch
>
>
> Due to more and more (welcomed) refactorings, TestDriver is becoming bigger and bigger.
Reducing code duplication is a good thing. But TestDriver begins to have too many responsibilities.
A solution would be to use composition in order to extract responsibilities from it.
> I currently see a few topics that could profit from it:
> * Errors recording
> * Distributed Cache
> * Counter validation
> You are welcome to suggest more. This work might in the end also help with the implementation
of the new API by providing a cleaner internal organisation of MRUnit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message