mrunit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Grote (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MRUNIT-198) Serialization is missing in MockMultipleOutputs
Date Tue, 04 Feb 2014 13:02:08 GMT

     [ https://issues.apache.org/jira/browse/MRUNIT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lars Grote updated MRUNIT-198:
------------------------------

    Attachment: MRUNIT-198.patch

This patch contains a fix for the described bug. Besides that it also includes the same functionality
for PathOutputs. 

{code}
mos.write(key, value, path)
{code}

Can somebody look at this and provide some feedback?
Thanks, Lars

> Serialization is missing in MockMultipleOutputs
> -----------------------------------------------
>
>                 Key: MRUNIT-198
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-198
>             Project: MRUnit
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Lars Grote
>             Fix For: 1.1.0
>
>         Attachments: MRUNIT-198.patch
>
>
> Hi, 
> with issue MRUNIT-13 MockMultipleOutputs was introduced. Which is great! Unfortunately
the inner class MockRecordWriter doesn't serialize the Object and therefore isn't storing
a copy of the Object but the Object itself. I would suggest to use org.apache.hadoop.mrunit.internal.output.MockOutputCollector
instead of the inner class. This Collector does store a copy of the Object and I see no point
in having more or less the same Collector/Writer twice. 
> Another thing that bugs me, is that MockMultipleOutputs requires you to use Comparable
Objects in your MR Jobs, and I don't see for what reason this restriction is imposed on me.
> I'll provide a patch for this soon and would be glad if someone can comment on it. 
> Cheers, Lars 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message