From dev-return-2198-apmail-mrunit-dev-archive=mrunit.apache.org@mrunit.apache.org Fri Feb 7 14:04:53 2014 Return-Path: X-Original-To: apmail-mrunit-dev-archive@www.apache.org Delivered-To: apmail-mrunit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE68B105CA for ; Fri, 7 Feb 2014 14:04:53 +0000 (UTC) Received: (qmail 19187 invoked by uid 500); 7 Feb 2014 14:04:53 -0000 Delivered-To: apmail-mrunit-dev-archive@mrunit.apache.org Received: (qmail 17971 invoked by uid 500); 7 Feb 2014 14:04:47 -0000 Mailing-List: contact dev-help@mrunit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mrunit.apache.org Delivered-To: mailing list dev@mrunit.apache.org Received: (qmail 17245 invoked by uid 99); 7 Feb 2014 14:04:41 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2014 14:04:41 +0000 Date: Fri, 7 Feb 2014 14:04:41 +0000 (UTC) From: "Lars Grote (JIRA)" To: dev@mrunit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MRUNIT-198) Serialization is missing in MockMultipleOutputs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MRUNIT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Grote updated MRUNIT-198: ------------------------------ Attachment: MRUNIT-198-1.patch Sorry! Use this path: MRUNIT-198-1.patch I build the first one the wrong way around. > Serialization is missing in MockMultipleOutputs > ----------------------------------------------- > > Key: MRUNIT-198 > URL: https://issues.apache.org/jira/browse/MRUNIT-198 > Project: MRUnit > Issue Type: Bug > Affects Versions: 1.1.0 > Reporter: Lars Grote > Fix For: 1.1.0 > > Attachments: MRUNIT-198-1.patch, MRUNIT-198.patch > > > Hi, > with issue MRUNIT-13 MockMultipleOutputs was introduced. Which is great! Unfortunately the inner class MockRecordWriter doesn't serialize the Object and therefore isn't storing a copy of the Object but the Object itself. I would suggest to use org.apache.hadoop.mrunit.internal.output.MockOutputCollector instead of the inner class. This Collector does store a copy of the Object and I see no point in having more or less the same Collector/Writer twice. > Another thing that bugs me, is that MockMultipleOutputs requires you to use Comparable Objects in your MR Jobs, and I don't see for what reason this restriction is imposed on me. > I'll provide a patch for this soon and would be glad if someone can comment on it. > Cheers, Lars -- This message was sent by Atlassian JIRA (v6.1.5#6160)