mrunit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Beech (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MRUNIT-208) mrunit unnecessarily depends on mockito-all
Date Wed, 30 Apr 2014 18:26:20 GMT

    [ https://issues.apache.org/jira/browse/MRUNIT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985876#comment-13985876
] 

Dave Beech commented on MRUNIT-208:
-----------------------------------

You're probably right about objenesis but I'll do a quick grep of mockito's code to see where
it's used. If it is just for some obscure feature of mockito we'll never touch then that's
OK. 

One thing I'm unsure about: should hamcrest have test scope in our pom? I think this means
it is in scope for our project's own unit tests but wouldn't be transitively brought down
and available in users' tests with mrunit. 

> mrunit unnecessarily depends on mockito-all
> -------------------------------------------
>
>                 Key: MRUNIT-208
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-208
>             Project: MRUnit
>          Issue Type: Improvement
>            Reporter: Alexandre Normand
>            Priority: Minor
>         Attachments: MRUNIT-208.patch
>
>
> mrunit depends on mockito but it brings it in as {{mockito-all}}. {{mockito-all}} bundles
{{hamcrest}} with it and makes it harder for downstream projects to manage/analyse their dependencies
cleanly. 
> I suggest that, to be a good citizen, mrunit declares explicit dependencies on {{mockito-core}}
instead as well as a {{test}} scoped dependency on {{hamcrest-core}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message