mrunit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexandre Normand (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MRUNIT-208) mrunit unnecessarily depends on mockito-all
Date Wed, 30 Apr 2014 20:35:19 GMT

    [ https://issues.apache.org/jira/browse/MRUNIT-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986038#comment-13986038
] 

Alexandre Normand commented on MRUNIT-208:
------------------------------------------

[~lukas.nalezenec]: Thanks for doing that. I wanted to check the dependencies before submitting
the patch but I'm getting a runtime error running the dependency plugin (only on mrunit):


{code}
alexandrenormand:~/projects/mrunit [git: trunk] $ mvn dependency:tree
[INFO] Scanning for projects...
[INFO]
[INFO] Using the builder org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder
with a thread count of 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building MRUnit 1.2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.5.1:tree (default-cli) @ mrunit ---
[WARNING] Error injecting: org.apache.maven.shared.dependency.graph.internal.Maven3DependencyGraphBuilder
java.lang.NoClassDefFoundError: org/sonatype/aether/graph/Dependency
	at java.lang.Class.getDeclaredMethods0(Native Method)
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2531)
...
{code}

> mrunit unnecessarily depends on mockito-all
> -------------------------------------------
>
>                 Key: MRUNIT-208
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-208
>             Project: MRUnit
>          Issue Type: Improvement
>            Reporter: Alexandre Normand
>            Priority: Minor
>         Attachments: MRUNIT-208.patch
>
>
> mrunit depends on mockito but it brings it in as {{mockito-all}}. {{mockito-all}} bundles
{{hamcrest}} with it and makes it harder for downstream projects to manage/analyse their dependencies
cleanly. 
> I suggest that, to be a good citizen, mrunit declares explicit dependencies on {{mockito-core}}
instead as well as a {{test}} scoped dependency on {{hamcrest-core}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message