mxnet-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junru Shao (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MXNET-1406) [BUG] Fix DLManagedTensor deleter
Date Tue, 21 May 2019 06:40:00 GMT
Junru Shao created MXNET-1406:
---------------------------------

             Summary: [BUG] Fix DLManagedTensor deleter
                 Key: MXNET-1406
                 URL: https://issues.apache.org/jira/browse/MXNET-1406
             Project: Apache MXNet
          Issue Type: Improvement
            Reporter: Junru Shao


## Description ##
This PR fixes a bug that causes recent crash in DGL. Please refer to https://github.com/dmlc/dlpack/issues/39
for details.

CC: @zheng-da

## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA
issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny
changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option
with NCCL)
- [x] Code is well-documented: 
- For user-facing API changes, API doc string has been updated. 
- For new C++ functions in header files, their functionalities and arguments are documented.

- For new examples, README.md is added to explain the what the example does, the source of
the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the my best knowledge, examples are either not affected by this change, or have been
fixed to be compatible with this change

### Changes ###
- [x] Allow `MXNDArrayFromDLPack` to accept an additional flag indicating whether the handle
will be freed before calling deleter.

## Comments ##
None



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org


Mime
View raw message