myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manol...@apache.org
Subject svn commit: r378284 - in /myfaces/tomahawk/trunk: core/pom.xml examples/pom.xml examples/simple/pom.xml examples/wap/pom.xml sandbox/core/pom.xml sandbox/examples/pom.xml
Date Thu, 16 Feb 2006 15:45:44 GMT
Author: manolito
Date: Thu Feb 16 07:45:42 2006
New Revision: 378284

URL: http://svn.apache.org/viewcvs?rev=378284&view=rev
Log:
fixed some maven dependencies to myfaces-impl

Modified:
    myfaces/tomahawk/trunk/core/pom.xml
    myfaces/tomahawk/trunk/examples/pom.xml
    myfaces/tomahawk/trunk/examples/simple/pom.xml
    myfaces/tomahawk/trunk/examples/wap/pom.xml
    myfaces/tomahawk/trunk/sandbox/core/pom.xml
    myfaces/tomahawk/trunk/sandbox/examples/pom.xml

Modified: myfaces/tomahawk/trunk/core/pom.xml
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/core/pom.xml?rev=378284&r1=378283&r2=378284&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/core/pom.xml (original)
+++ myfaces/tomahawk/trunk/core/pom.xml Thu Feb 16 07:45:42 2006
@@ -32,13 +32,19 @@
       <groupId>org.apache.myfaces.core</groupId>
       <artifactId>myfaces-impl</artifactId>
       <version>1.1.3-SNAPSHOT</version>
-      <scope>provided</scope>
+      <!--
+        Since Tomahawk must stay compatible to other JSF implementations we
+        must not have any (compile time) dependency on myfaces-impl other than
+        test classes.
+      -->
+      <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.apache.myfaces.commons</groupId>
       <artifactId>myfaces-commons</artifactId>
       <version>1.1.3-SNAPSHOT</version>
+      <scope>compile</scope>
     </dependency>
 
     <dependency>

Modified: myfaces/tomahawk/trunk/examples/pom.xml
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/examples/pom.xml?rev=378284&r1=378283&r2=378284&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/examples/pom.xml (original)
+++ myfaces/tomahawk/trunk/examples/pom.xml Thu Feb 16 07:45:42 2006
@@ -41,6 +41,11 @@
       <groupId>org.apache.myfaces.core</groupId>
       <artifactId>myfaces-impl</artifactId>
       <version>1.1.3-SNAPSHOT</version>
+      <!-- Tomahawk examples must only have runtime dependency to myfaces-impl
+           so that it will be automatically added to war. But there must not be
+           any compile dependency on impl so that is is always possible to use
+           other JSF implementations. -->
+      <scope>runtime</scope>
     </dependency>    
   </dependencies>
 

Modified: myfaces/tomahawk/trunk/examples/simple/pom.xml
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/examples/simple/pom.xml?rev=378284&r1=378283&r2=378284&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/examples/simple/pom.xml (original)
+++ myfaces/tomahawk/trunk/examples/simple/pom.xml Thu Feb 16 07:45:42 2006
@@ -37,4 +37,13 @@
     <finalName>myfaces-example-simple</finalName>
   </build>
 
+  <dependencies>
+    <dependency>
+      <groupId>commons-logging</groupId>
+      <artifactId>commons-logging</artifactId>
+      <version>1.0.4</version>
+      <scope>compile</scope>
+    </dependency>
+  </dependencies>
+
 </project>

Modified: myfaces/tomahawk/trunk/examples/wap/pom.xml
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/examples/wap/pom.xml?rev=378284&r1=378283&r2=378284&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/examples/wap/pom.xml (original)
+++ myfaces/tomahawk/trunk/examples/wap/pom.xml Thu Feb 16 07:45:42 2006
@@ -37,4 +37,13 @@
     <finalName>myfaces-example-wap</finalName>
   </build>
 
+    <dependencies>
+      <dependency>
+        <groupId>commons-logging</groupId>
+        <artifactId>commons-logging</artifactId>
+        <version>1.0.4</version>
+        <scope>compile</scope>
+      </dependency>
+    </dependencies>
+
 </project>

Modified: myfaces/tomahawk/trunk/sandbox/core/pom.xml
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/sandbox/core/pom.xml?rev=378284&r1=378283&r2=378284&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/pom.xml (original)
+++ myfaces/tomahawk/trunk/sandbox/core/pom.xml Thu Feb 16 07:45:42 2006
@@ -42,6 +42,8 @@
       <groupId>org.apache.myfaces.core</groupId>
       <artifactId>myfaces-impl</artifactId>
       <version>1.1.3-SNAPSHOT</version>
+      <!-- TODO: This must be fixed ASAP!
+                 Sandbox components must not have any dependency to myfaces-impl -->
       <scope>provided</scope>
     </dependency>
 

Modified: myfaces/tomahawk/trunk/sandbox/examples/pom.xml
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/sandbox/examples/pom.xml?rev=378284&r1=378283&r2=378284&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/examples/pom.xml (original)
+++ myfaces/tomahawk/trunk/sandbox/examples/pom.xml Thu Feb 16 07:45:42 2006
@@ -54,6 +54,11 @@
       <groupId>org.apache.myfaces.core</groupId>
       <artifactId>myfaces-impl</artifactId>
       <version>1.1.3-SNAPSHOT</version>
-    </dependency>        
+      <!-- Sandbox examples must only have runtime dependency to myfaces-impl
+           so that it will be automatically added to war. But there must not be
+           any compile dependency on impl so that is is always possible to use
+           other JSF implementations. -->
+      <scope>runtime</scope>
+    </dependency>
   </dependencies>
 </project>



Mime
View raw message