myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mat...@apache.org
Subject svn commit: r751991 - /myfaces/trinidad/branches/1.2.11.1-branch/trinidad-impl/src/main/javascript/META-INF/adf/jsLibs/Core.js
Date Tue, 10 Mar 2009 06:24:32 GMT
Author: matzew
Date: Tue Mar 10 06:24:31 2009
New Revision: 751991

URL: http://svn.apache.org/viewvc?rev=751991&view=rev
Log:
TRINIDAD-1391 - Enable PPR on BlackBerry Bold and Storm

Thanks to Tadashi Enomori for the patch

Modified:
    myfaces/trinidad/branches/1.2.11.1-branch/trinidad-impl/src/main/javascript/META-INF/adf/jsLibs/Core.js

Modified: myfaces/trinidad/branches/1.2.11.1-branch/trinidad-impl/src/main/javascript/META-INF/adf/jsLibs/Core.js
URL: http://svn.apache.org/viewvc/myfaces/trinidad/branches/1.2.11.1-branch/trinidad-impl/src/main/javascript/META-INF/adf/jsLibs/Core.js?rev=751991&r1=751990&r2=751991&view=diff
==============================================================================
--- myfaces/trinidad/branches/1.2.11.1-branch/trinidad-impl/src/main/javascript/META-INF/adf/jsLibs/Core.js
(original)
+++ myfaces/trinidad/branches/1.2.11.1-branch/trinidad-impl/src/main/javascript/META-INF/adf/jsLibs/Core.js
Tue Mar 10 06:24:31 2009
@@ -315,12 +315,30 @@
     // BlackBerry Browser 4.0+ supports navigator.appVersion,
     // and earlier versions don't support script, so we can
     // leave the version as defined above
-    pprUnsupported = true;
+
+    // BlackBerryXXXX/Y.Y.Y.Y is the BlackBerry user agent format
+    // XXXX is the model number and Y.Y.Y.Y is the OS version number.
+    // At this moment, BlackBerry below version 4.6 is regarded as 
+    // basic HTML browser for the JS performance reason.
+    // The following lines should be uncommented when we decide to 
+    // handle BlackBerry version 4.0~4.5 separate from the batch of
+    // Basic HTML browsers after its JS performance improves.
+    /*
+    var versionStart = agentString.substring(agentString.indexOf(
+                                                      "blackberry") + 9);
+    versionStart = versionStart.substring(versionStart.indexOf("/") + 1);
+    version = parseFloat(versionStart);
+
+    if (version < 4.6)
+    {
+      pprUnsupported = true;
+      supportsDomDocument = false;
+      supportsValidation = false;
+    }
+    */
+    
     isBlackBerry = true;
     kind = "blackberry";
-    mobileBrowser = true;
-    supportsDomDocument = false;
-    supportsValidation = false;
   }
   else if ((agentString.indexOf('mozilla')    != -1) &&
            (agentString.indexOf('spoofer')    == -1) &&



Mime
View raw message