myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lu4...@apache.org
Subject svn commit: r814242 - in /myfaces/core/trunk/impl/src: main/java/org/apache/myfaces/lifecycle/RestoreViewExecutor.java test/java/org/apache/myfaces/lifecycle/RestoreViewExecutorTest.java
Date Sat, 12 Sep 2009 21:33:25 GMT
Author: lu4242
Date: Sat Sep 12 21:33:24 2009
New Revision: 814242

URL: http://svn.apache.org/viewvc?rev=814242&view=rev
Log:
MYFACES-2002 Implement section 2.2.1 of the EDR2 specification (rollback call to UIViewRoot.subscribeToEvent
because it was removed on PR)

Modified:
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/lifecycle/RestoreViewExecutor.java
    myfaces/core/trunk/impl/src/test/java/org/apache/myfaces/lifecycle/RestoreViewExecutorTest.java

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/lifecycle/RestoreViewExecutor.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/lifecycle/RestoreViewExecutor.java?rev=814242&r1=814241&r2=814242&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/lifecycle/RestoreViewExecutor.java
(original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/lifecycle/RestoreViewExecutor.java
Sat Sep 12 21:33:24 2009
@@ -138,7 +138,9 @@
                 
                 // Subscribe the newly created UIViewRoot instance to the AfterAddToParent
event, passing the 
                 // UIViewRoot instance itself as the listener.
-                viewRoot.subscribeToEvent(PostAddToViewEvent.class, viewRoot);
+                // -= Leonardo Uribe =- This line it is not necessary because it was
+                // removed from jsf 2.0 section 2.2.1 when pass from EDR2 to Public Review

+                // viewRoot.subscribeToEvent(PostAddToViewEvent.class, viewRoot);
                 
                 // Store the new UIViewRoot instance in the FacesContext.
                 facesContext.setViewRoot(viewRoot);

Modified: myfaces/core/trunk/impl/src/test/java/org/apache/myfaces/lifecycle/RestoreViewExecutorTest.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/test/java/org/apache/myfaces/lifecycle/RestoreViewExecutorTest.java?rev=814242&r1=814241&r2=814242&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/test/java/org/apache/myfaces/lifecycle/RestoreViewExecutorTest.java
(original)
+++ myfaces/core/trunk/impl/src/test/java/org/apache/myfaces/lifecycle/RestoreViewExecutorTest.java
Sat Sep 12 21:33:24 2009
@@ -86,7 +86,7 @@
         _facesContext.renderResponse();
 
         UIViewRoot viewRoot = _mocksControl.createMock(UIViewRoot.class);
-        viewRoot.subscribeToEvent(same(PostAddToViewEvent.class), same(viewRoot));
+        //viewRoot.subscribeToEvent(same(PostAddToViewEvent.class), same(viewRoot));
 
         ViewDeclarationLanguage vdl = _mocksControl.createMock(ViewDeclarationLanguage.class);
         expect(_viewHandler.getViewDeclarationLanguage(same(_facesContext), eq("calculatedViewId")))



Mime
View raw message