myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwald...@apache.org
Subject svn commit: r819087 - in /myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml: NavigationPaneRenderer.java SelectRangeChoiceBarRenderer.java
Date Sat, 26 Sep 2009 01:59:40 GMT
Author: jwaldman
Date: Sat Sep 26 01:59:39 2009
New Revision: 819087

URL: http://svn.apache.org/viewvc?rev=819087&view=rev
Log:
TRINIDAD-1556  In mobile non-JavaScript browsers, style-classes for <tr:selectRangeChoiceBar>
and <tr:navigationPane> are not rendered
patch by Mamallan Uthaman

Modified:
    myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/NavigationPaneRenderer.java
    myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SelectRangeChoiceBarRenderer.java

Modified: myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/NavigationPaneRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/NavigationPaneRenderer.java?rev=819087&r1=819086&r2=819087&view=diff
==============================================================================
--- myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/NavigationPaneRenderer.java
(original)
+++ myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/NavigationPaneRenderer.java
Sat Sep 26 01:59:39 2009
@@ -704,7 +704,8 @@
       rw.writeAttribute("name", XhtmlUtils.getEncodedParameter
                                   (XhtmlConstants.SOURCE_PARAM)
                                    + clientId, null);
-    
+      renderStyleClass(context, arc, 
+                  SkinSelectors.AF_COMMAND_BUTTON_STYLE_CLASS);
       String linkConverter = 
              "border:none;background:inherit;text-decoration:underline;";
     
@@ -777,9 +778,10 @@
       rw.writeAttribute("accessKey", accessKey, null);
     }
     
+    // In the case of HTML basic browsers, we render an input element. Hence, 
+    // we cannot render any children, so skip calling _renderCommandChildren
     if (nonJavaScriptSubmit)
     { 
-      _renderCommandChildren(context, commandChild);
       rw.endElement("input"); 
     }
     else

Modified: myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SelectRangeChoiceBarRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SelectRangeChoiceBarRenderer.java?rev=819087&r1=819086&r2=819087&view=diff
==============================================================================
--- myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SelectRangeChoiceBarRenderer.java
(original)
+++ myfaces/trinidad/branches/1.2.12.1-branch/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SelectRangeChoiceBarRenderer.java
Sat Sep 26 01:59:39 2009
@@ -1064,10 +1064,12 @@
       writer.writeAttribute("type", "submit", null);
       writer.writeAttribute("name", nameAttri, null);
       writer.writeAttribute("value", text, "text");
+      renderStyleClass(context, arc, 
+                  SkinSelectors.AF_COMMAND_BUTTON_STYLE_CLASS);
+                  
       // This style makes a button to appear as a link
       writer.writeAttribute("style",
         "border:none;background:inherit;text-decoration:underline;",null);
-      renderStyleClass(context, arc, SkinSelectors.NAV_BAR_ALINK_STYLE_CLASS);
       writer.endElement("input");
     }
 



Mime
View raw message