myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jak...@apache.org
Subject svn commit: r930299 - /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
Date Fri, 02 Apr 2010 15:44:32 GMT
Author: jakobk
Date: Fri Apr  2 15:44:32 2010
New Revision: 930299

URL: http://svn.apache.org/viewvc?rev=930299&view=rev
Log:
MYFACES-2641 Use the application's ViewHandler to create the view in FaceletViewMetadata

Modified:
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java?rev=930299&r1=930298&r2=930299&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
(original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
Fri Apr  2 15:44:32 2010
@@ -2062,8 +2062,11 @@ public class FaceletViewDeclarationLangu
                 
                 context.getAttributes().put(BUILDING_VIEW_METADATA, Boolean.TRUE);
 
-                String viewId = getViewId();
-                UIViewRoot view = createView(context, viewId);
+                // we have to invoke createView() on the application's ViewHandler
+                // here instead of invoking it directly in FaceletVDL, because
+                // the ViewHandler might be wrapped and wants to do some work
+                // in createView() (e.g. in Trinidad - see MYFACES-2641)
+                UIViewRoot view = context.getApplication().getViewHandler().createView(context,
getViewId());
                 // inside createView(context,viewId), calculateViewId() is called and
                 // the result is stored inside created UIViewRoot, so we can safely take
the derived
                 // viewId from there.



Mime
View raw message