myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwald...@apache.org
Subject svn commit: r934999 - /myfaces/trinidad-maven/trunk/maven-tagdoc-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/tagdoc/TagdocReport.java
Date Fri, 16 Apr 2010 17:14:34 GMT
Author: jwaldman
Date: Fri Apr 16 17:14:33 2010
New Revision: 934999

URL: http://svn.apache.org/viewvc?rev=934999&view=rev
Log:
TRINIDAD-1731 Improve Formatting of Tag Doc Summary section
changed String.isEmpty() to check length() since trinidad-maven trunk is compiled against
1.5, and String.isEmpty was added in 1.6.

Modified:
    myfaces/trinidad-maven/trunk/maven-tagdoc-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/tagdoc/TagdocReport.java

Modified: myfaces/trinidad-maven/trunk/maven-tagdoc-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/tagdoc/TagdocReport.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad-maven/trunk/maven-tagdoc-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/tagdoc/TagdocReport.java?rev=934999&r1=934998&r2=934999&view=diff
==============================================================================
--- myfaces/trinidad-maven/trunk/maven-tagdoc-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/tagdoc/TagdocReport.java
(original)
+++ myfaces/trinidad-maven/trunk/maven-tagdoc-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/tagdoc/TagdocReport.java
Fri Apr 16 17:14:33 2010
@@ -322,7 +322,8 @@ public class TagdocReport extends Abstra
 
     // In the case of the component summary, the header is written out in a separate table
cell, and so no
     // header text is passed into this method
-    if (header != null && !header.isEmpty())
+    // TODO use !header.isEmpty() on jdk1.6
+    if (header != null && !(header.length() == 0))
     {
       sb.append("<b>");
       sb.append(header);
@@ -384,7 +385,8 @@ public class TagdocReport extends Abstra
 
       // In the case of the component summary section the header text is written out
       // in a separate table cell, so no header text is passed into this method
-      if (header != null && !header.isEmpty())
+      // TODO use !header.isEmpty() on jdk1.6
+      if (header != null && !(header.length() == 0))
       {
         sb.append("<b>");
         sb.append(header);
@@ -698,7 +700,8 @@ public class TagdocReport extends Abstra
 
     // Write out the corresponding Java Script class for this component with a link to its
JavaScript doc
     String jsClass = bean.getJsComponentClass();
-    if (jsClass != null && !jsClass.isEmpty()) 
+    // TODO use !header.isEmpty() on jdk1.6
+    if (jsClass != null && !(jsClass.length() == 0)) 
     {
       out.write("<tr>\n");
       out.write("<td><b>JavaScript Class:</b></td>");



Mime
View raw message