myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lof...@apache.org
Subject svn commit: r1523549 - /myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
Date Mon, 16 Sep 2013 07:24:10 GMT
Author: lofwyr
Date: Mon Sep 16 07:24:10 2013
New Revision: 1523549

URL: http://svn.apache.org/r1523549
Log:
TOBAGO-1311: Method prepareRender() will not be called for tree nodes in sheets 
 - this is turned off in the moment, because otherwise we got an NullPointerException
 - the problem is, that there is no rowId set
   - a solution would be, to set

Modified:
    myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java

Modified: myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java?rev=1523549&r1=1523548&r2=1523549&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
(original)
+++ myfaces/tobago/trunk/tobago-theme/tobago-theme-scarborough/src/main/java/org/apache/myfaces/tobago/renderkit/html/scarborough/standard/tag/SheetRenderer.java
Mon Sep 16 07:24:10 2013
@@ -1099,7 +1099,16 @@ public class SheetRenderer extends Layou
   public void prepareRendersChildren(FacesContext facesContext, UIComponent component) throws
IOException {
     UISheet sheet = (UISheet) component;
     for (UIColumn column : sheet.getRenderedColumns()) {
-      RenderUtils.prepareRendererAll(facesContext, column);
+      if (column instanceof AbstractUIColumnNode) {
+        if (LOG.isDebugEnabled()) {
+          LOG.debug("TODO: AbstractUIColumnNode are not prepared.");
+        }
+        // TBD: when the column should be prepared for rendering, I think we need to
+        // TBD: iterate over each row to prepare it.
+        // TBD: in the moment this method TreeNodeRendererBase.prepareRender() will not be
called in sheets
+      } else {
+        RenderUtils.prepareRendererAll(facesContext, column);
+      }
     }
   }
 }



Mime
View raw message