myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hno...@apache.org
Subject svn commit: r1792205 - in /myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal: renderkit/renderer/TabGroupRenderer.java taglib/component/TabGroupTagDeclaration.java
Date Fri, 21 Apr 2017 13:38:25 GMT
Author: hnoeth
Date: Fri Apr 21 13:38:24 2017
New Revision: 1792205

URL: http://svn.apache.org/viewvc?rev=1792205&view=rev
Log:
TOBAGO-1710 tc:tabGroup currently not supports showNavigationBar
* tabGroup header is now not rendered by showNavigationBar=false

Modified:
    myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java
    myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/TabGroupTagDeclaration.java

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java?rev=1792205&r1=1792204&r2=1792205&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java
(original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java
Fri Apr 21 13:38:24 2017
@@ -162,7 +162,9 @@ public class TabGroupRenderer extends Re
     writer.writeIdAttribute(hiddenId);
     writer.endElement(HtmlElements.INPUT);
 
-    encodeHeader(facesContext, writer, tabGroup, activeIndex, switchType);
+    if (tabGroup.isShowNavigationBar()) {
+      encodeHeader(facesContext, writer, tabGroup, activeIndex, switchType);
+    }
 
     encodeContent(facesContext, writer, tabGroup, activeIndex, switchType);
 

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/TabGroupTagDeclaration.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/TabGroupTagDeclaration.java?rev=1792205&r1=1792204&r2=1792205&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/TabGroupTagDeclaration.java
(original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/TabGroupTagDeclaration.java
Fri Apr 21 13:38:24 2017
@@ -61,7 +61,6 @@ public interface TabGroupTagDeclaration
 
   /**
    * Flag indicating that the tab navigation bar is rendered.
-   * Currently this attribute has no effect (see issue TOBAGO-1710).
    */
   @TagAttribute
   @UIComponentTagAttribute(type = "boolean", defaultValue = "true")



Mime
View raw message