myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lof...@apache.org
Subject svn commit: r1803811 - in /myfaces/tobago/trunk: tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/declaration/ tobago-example/tobago-example-demo/src/main/webapp/content/20-component/040-command/00-button+link/
Date Wed, 02 Aug 2017 12:00:36 GMT
Author: lofwyr
Date: Wed Aug  2 12:00:36 2017
New Revision: 1803811

URL: http://svn.apache.org/viewvc?rev=1803811&view=rev
Log:
TOBAGO-1752: DeltaSpike WindowId doesn't work correctly with Tobago
* Document problem with target attribute.

Modified:
    myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/declaration/HasTarget.java
    myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/040-command/00-button+link/button+link.xhtml

Modified: myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/declaration/HasTarget.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/declaration/HasTarget.java?rev=1803811&r1=1803810&r2=1803811&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/declaration/HasTarget.java
(original)
+++ myfaces/tobago/trunk/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/declaration/HasTarget.java
Wed Aug  2 12:00:36 2017
@@ -26,6 +26,11 @@ public interface HasTarget {
   /**
    * Name of a frame where the resource retrieved via this hyperlink is to be
    * displayed.
+   *
+   * The target attribute is not reliable in combination with
+   * DeltaSpike and its @WindowScoped.
+   * This is because DeltaSpike renames the window.name, with the dswid, so the
+   * target can't be found, after the first call.
    */
   @TagAttribute
   @UIComponentTagAttribute()

Modified: myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/040-command/00-button+link/button+link.xhtml
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/040-command/00-button%2Blink/button%2Blink.xhtml?rev=1803811&r1=1803810&r2=1803811&view=diff
==============================================================================
--- myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/040-command/00-button+link/button+link.xhtml
(original)
+++ myfaces/tobago/trunk/tobago-example/tobago-example-demo/src/main/webapp/content/20-component/040-command/00-button+link/button+link.xhtml
Wed Aug  2 12:00:36 2017
@@ -20,7 +20,8 @@
                 xmlns:tc="http://myfaces.apache.org/tobago/component"
                 xmlns:ui="http://java.sun.com/jsf/facelets"
                 xmlns:f="http://java.sun.com/jsf/core"
-                xmlns:h="http://java.sun.com/jsf/html">
+                xmlns:h="http://java.sun.com/jsf/html"
+                xmlns:demo="http://myfaces.apache.org/tobago/example/demo">
   <ui:param name="title" value="#{demoBundle.button_link} &lt;tc:link> &lt;tc:button>"/>
   <p>A classic link can be set with the <code class="language-markup">&lt;tc:link/></code>
tag.
     You can also set a link by <code class="language-markup">&lt;tc:button/></code>.
@@ -137,6 +138,13 @@
   </tc:section>
 
   <tc:section label="Target">
+    <p>
+      <span class="#{demo:bootstrapClass('BADGE')} #{demo:bootstrapClass('BADGE_WARNING')}">Warning!</span>
+      The <code class="language-markup">target</code> attribute is not reliable
in combination with
+      <tc:link link="https://deltaspike.apache.org/" label="DeltaSpike"/> and its @WindowScoped.
+      This is because DeltaSpike renames the <code>window.name</code>, with the
<code>dswid</code>, so the
+      target can't be found, after the first call.
+    </p>
     <p>The destination of the link can be set with the <code>target</code>
attribute.
       For example a new window/tab or a specific iframe (<code class="language-markup">&lt;tc:object/></code>).</p>
     <tc:section label="New Window">



Mime
View raw message