myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hno...@apache.org
Subject [myfaces-tobago] branch tobago-4.x updated: TOBAGO-1947 Sorting in sheet requires setter
Date Thu, 01 Nov 2018 12:34:42 GMT
This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch tobago-4.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/tobago-4.x by this push:
     new 42c2fff  TOBAGO-1947 Sorting in sheet requires setter
42c2fff is described below

commit 42c2fffb3239dad86622219e4aa492cac3b1c92e
Author: Henning Noeth <hnoeth@apache.org>
AuthorDate: Thu Nov 1 11:56:48 2018 +0100

    TOBAGO-1947 Sorting in sheet requires setter
    
    * sorting now requires only a getter (as it was in Tobago 2)
    
    (cherry picked from commit 7dcbe82a5248b2bb9f497453dc4f596502b62f1c)
---
 .../src/main/java/org/apache/myfaces/tobago/util/BeanComparator.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/util/BeanComparator.java
b/tobago-core/src/main/java/org/apache/myfaces/tobago/util/BeanComparator.java
index 0dd1c1c..5998a8f 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/util/BeanComparator.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/util/BeanComparator.java
@@ -88,8 +88,8 @@ public class BeanComparator extends ComparatorBase implements Serializable
{
     final Object obj1;
     final Object obj2;
     try {
-      obj1 = new PropertyDescriptor(property, param1.getClass()).getReadMethod().invoke(param1);
-      obj2 = new PropertyDescriptor(property, param1.getClass()).getReadMethod().invoke(param2);
+      obj1 = new PropertyDescriptor(property, param1.getClass(), property, null).getReadMethod().invoke(param1);
+      obj2 = new PropertyDescriptor(property, param1.getClass(), property, null).getReadMethod().invoke(param2);
     } catch (final Exception e) {
       LOG.error(e.getMessage(), e);
       return 0;


Mime
View raw message