myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hno...@apache.org
Subject [myfaces-tobago] branch tobago-4.x updated: fix: aria-labelledby for dropdown menus
Date Thu, 02 Apr 2020 12:45:40 GMT
This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch tobago-4.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/tobago-4.x by this push:
     new 8808e3a  fix: aria-labelledby for dropdown menus
8808e3a is described below

commit 8808e3a2930982b433f13572cd8172ab952bf733
Author: Henning Nöth <hnoeth@apache.org>
AuthorDate: Wed Apr 1 15:53:57 2020 +0200

    fix: aria-labelledby for dropdown menus
    
    The aria-labelledby attribute for dropdown menus has now the ID of the button which opens
the dropdown menu.
    
    (cherry picked from commit 3ef846273a594ce72cab8e73eafdc16c22b6fe07)
---
 .../myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java
b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java
index 560930a..25694ba 100644
--- a/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java
+++ b/tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/CommandRendererBase.java
@@ -167,7 +167,7 @@ public abstract class CommandRendererBase extends DecodingCommandRendererBase
{
       writer.writeClassAttribute(
           BootstrapClass.DROPDOWN_MENU,
           getDropdownCssItems(facesContext, command));
-      writer.writeAttribute(Arias.LABELLEDBY, "dropdownMenuButton", false);
+      writer.writeAttribute(Arias.LABELLEDBY, command.getFieldId(facesContext), false);
 
       for (final UIComponent child : component.getChildren()) {
         if (child.isRendered()


Mime
View raw message