nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Bress <dbr...@onyxconsults.com>
Subject Re: [GitHub] incubator-nifi pull request: NIFI-280 take two
Date Wed, 04 Feb 2015 13:59:25 GMT
Mark,
   I tried what you suggested last night, and in my opinion, now the table is a little too
sparse looking.  Maybe CSS magic can help, but right now I think it looks a little naked.
 I don't have the tooltip over the "info" icon working yet.  But this gives you an idea of
what it would look like.

   I tried another idea of rendering the description as a second row below the description/default
values/valid values/expression language row.  I kinda like this, although it definitely needs
CSS magic to make it not confusing.  Right now I just slammed it to the right to make it not
get mixed up with the property name on the left.  I think playing with row colors or borders
a little may make it clearer, I'll play with this later and let me know what you think.

   I've supplied three renderings.  How it was originally working[1], putting the description
in a tool tip as Mark suggested[2], moving the description to a second row[3].  Let me know
if what you like/don't like.

[1] http://danbress.github.io/generated-documentation/components-02032015a/org.apache.nifi.processors.standard.GetFTP/index.html
[2] http://danbress.github.io/generated-documentation/components-02032015b/org.apache.nifi.processors.standard.GetFTP/index.html
[3] http://danbress.github.io/generated-documentation/components-02032015c/org.apache.nifi.processors.standard.GetFTP/index.html

Dan Bress
Software Engineer
ONYX Consulting Services

________________________________________
From: Daniel Bress <dbress@onyxconsults.com>
Sent: Tuesday, February 3, 2015 4:44 PM
To: dev@nifi.incubator.apache.org
Subject: Re: [GitHub] incubator-nifi pull request: NIFI-280 take two

Mark,
  I'm on board with you.  I think the table layout can be made better with your suggestions.
 I'll give your suggestions a shot and share the results later tonight.  Thanks!

  Another thing I noticed is that the "bold" for the required properties is not that bold.
 I think the style should could be tweaked a little to improve this.

Dan Bress
Software Engineer
ONYX Consulting Services

________________________________________
From: Mark Payne <markap14@hotmail.com>
Sent: Tuesday, February 3, 2015 9:37 AM
To: dev@nifi.incubator.apache.org
Subject: Re: [GitHub] incubator-nifi pull request: NIFI-280 take two

Dan,


I pulled this in and started looking around. It all appears to work well.


I’m a bit concerned about the table layout though for properties: it gets pretty cramped,
and it looks like the two columns “Default” and “Values” are a single column: “Default
Values”. Also, there’s no description that I can see for the Allowable Values.


I would suggest a bit of an alternate layout here: rather than having the Description in the
table, having an “Info” icon that the user can hover over that provides a tooltip with
the description, similar to how it’s done in the Processor Configuration dialog in the application.
This frees up a lot of space in the table. Then, if there are descriptions for the Allowable
Values, we can also have the same construct for getting the Description of the Allowable Value.
We can also then expand the table headers to “Default Value,” “Allowable Values,”
and “Expression Language” rather than using abbreviations.


What do you think of this approach?


The only other thing that I've noticed is in the  blurb about Properties, it has “any other”
as a single word “Anyother.” 😊








From: danbress
Sent: ‎Monday‎, ‎February‎ ‎2‎, ‎2015 ‎9‎:‎10‎ ‎PM
To: dev@nifi.incubator.apache.org





Github user danbress commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/14#issuecomment-72579336

    Just pulled out the license generation.  Let me know if there are any other problems.
 Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Mime
View raw message