nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Payne <marka...@hotmail.com>
Subject Re: [GitHub] incubator-nifi pull request: NIFI-280 take two
Date Tue, 03 Feb 2015 14:37:12 GMT
Dan,


I pulled this in and started looking around. It all appears to work well.


I’m a bit concerned about the table layout though for properties: it gets pretty cramped,
and it looks like the two columns “Default” and “Values” are a single column: “Default
Values”. Also, there’s no description that I can see for the Allowable Values.


I would suggest a bit of an alternate layout here: rather than having the Description in the
table, having an “Info” icon that the user can hover over that provides a tooltip with
the description, similar to how it’s done in the Processor Configuration dialog in the application.
This frees up a lot of space in the table. Then, if there are descriptions for the Allowable
Values, we can also have the same construct for getting the Description of the Allowable Value.
We can also then expand the table headers to “Default Value,” “Allowable Values,”
and “Expression Language” rather than using abbreviations.


What do you think of this approach? 


The only other thing that I've noticed is in the  blurb about Properties, it has “any other”
as a single word “Anyother.” 😊








From: danbress
Sent: ‎Monday‎, ‎February‎ ‎2‎, ‎2015 ‎9‎:‎10‎ ‎PM
To: dev@nifi.incubator.apache.org





Github user danbress commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/14#issuecomment-72579336
  
    Just pulled out the license generation.  Let me know if there are any other problems.
 Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message