nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Witt <joe.w...@gmail.com>
Subject Re: [GitHub] incubator-nifi pull request: NIFI-280 take two
Date Mon, 02 Feb 2015 20:02:15 GMT
Mark,

I believe you have it correct.  Headers are not required on generated
items.  They are required on all source files with 'few exceptions'[1].

As long as these HTML documents are being built during the build phase that
makes them not part of the source.  Remember the official release of apache
nifi are the source materials.  The resulting binaries are not the
releasable item as they are not 'open source'.

[1] http://www.apache.org/legal/src-headers.html#faq-exceptions

Anyone think I have this wrong?

Thanks
Joe

On Mon, Feb 2, 2015 at 2:33 PM, Mark Payne <markap14@hotmail.com> wrote:

> Dan,
> Looked over this contribution. Excellent work here - will make all of our
> lives much easier! :)
> Only thing I'm really unsure about here is when you are generating HTML,
> you are including the Apache header into the generated HTML page and I'm
> not sure that it should go in there.
> If it were a document that went into our CM it would definitely need it.
> However, this is something that is getting auto-generated by NiFi at
> runtime, and it would be adding Apache License headers to documentation for
> components that are not part of Apache NiFi.
> Can anyone confirm that I am correct here, that it doesn't need to be in
> the artifacts that NiFi generates at runtime or otherwise correct me if I'm
> wrong?
> Thanks-Mark
>
> > From: git@git.apache.org
> > To: dev@nifi.incubator.apache.org
> > Subject: [GitHub] incubator-nifi pull request: NIFI-280 take two
> > Date: Sat, 31 Jan 2015 18:01:43 +0000
> >
> > GitHub user danbress opened a pull request:
> >
> >     https://github.com/apache/incubator-nifi/pull/14
> >
> >     NIFI-280 take two
> >
> >     Second try and NIFI-280's merge request.  Squashed my commits.
> Hopefully this time works better
> >
> > You can merge this pull request into a Git repository by running:
> >
> >     $ git pull https://github.com/danbress/incubator-nifi NIFI-280-take2
> >
> > Alternatively you can review and apply these changes as the patch at:
> >
> >     https://github.com/apache/incubator-nifi/pull/14.patch
> >
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> >     This closes #14
> >
> > ----
> > commit 0b00aa18b051b14f29040cbfa94d8c04e4d82f81
> > Author: danbress <dbress@onyxconsults.com>
> > Date:   2015-01-31T14:02:23Z
> >
> >     NIFI-280 - Adding new documentation framework component and
> incorporating
> >     in framework
> >
> > commit f554f3d1b4a1561fae8b4828aa6c3688e2d8261b
> > Author: danbress <dbress@onyxconsults.com>
> > Date:   2015-01-31T17:29:07Z
> >
> >     NIFI-280 rewording column headers and warning message
> >
> > commit 30c652de4a54e3a00b2a6656bc457ccefa8c4a29
> > Author: danbress <dbress@onyxconsults.com>
> > Date:   2015-01-31T17:56:25Z
> >
> >     NIFI-280 - Modifing existing existing documentation
> >     removing index.html and renaming to additionalDetails.html if there
> is relevent information
> >
> > ----
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message