nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apiri <...@git.apache.org>
Subject [GitHub] incubator-nifi pull request: NIFI-606 Add a NiFi Storm Spout
Date Fri, 05 Jun 2015 16:43:09 GMT
Github user apiri commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/61#issuecomment-109358436
  
    Bryan, good stuff.
    
    Thanks for the detailed instructions and samples to get this tested in an appreciable
fashion with Storm. 
    
    Minor points:  Camel casing of the NiFiDataPacket variable.
    Also, since this PR was submitted, and due to the number of contributions and features
under way, the develop branch has since been migrated to 0.2.0.  
    
    If you would like, I do not mind I can make these changes for your patch upon merge, but
if you would prefer to do so yourself and update the PR, that also works.
    
    Let me know your thoughts.
    
    +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message