nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <...@git.apache.org>
Subject [GitHub] nifi pull request: [NIFI-784] RouteOnAttribute Performance Improve...
Date Wed, 12 Aug 2015 15:01:32 GMT
Github user madrob commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/71#discussion_r36870124
  
    --- Diff: nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java
---
    @@ -236,7 +259,7 @@ public void onTrigger(final ProcessContext context, final ProcessSession
session
     
                 // now transfer any clones generated
                 for (final Map.Entry<Relationship, FlowFile> entry : transferMap.entrySet())
{
    -                logger.info(this + " cloned " + flowFile + " into " + entry.getValue()
+ " and routing clone to relationship " + entry.getKey());
    +                logger.info("Cloned {} into {} and routing clone to relationship {}",
new Object[]{ flowFile, entry.getValue(), entry.getKey() });
    --- End diff --
    
    Are we moving away from logging 'this'? I've seen those messages be incredibly useful
in the past...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message