nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danbress <...@git.apache.org>
Subject [GitHub] nifi pull request: [NIFI-774] Create a DeleteS3Object Processor
Date Thu, 13 Aug 2015 13:35:52 GMT
Github user danbress commented on the pull request:

    https://github.com/apache/nifi/pull/72#issuecomment-130674437
  
    Yu,
       Thanks for working through this.  There are a few things I still think you need to
do:
    
       1) I made comments on line 70 and 61 that I think you need to consider.  I do not believe
you need to override "getSupportedDynamicPropertyDescriptors", but in order for that to work
you must add "VERSION_ID" to the "properties" list on line 60/61.
    
       2) I think you need to add this class to the service descriptor file located here:
nifi-aws-processors/src/main/resources/META-INF/services/org.apache.nifi.processor.Processor
    
    Thanks again!
    
    Dan


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message