nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trkurc <...@git.apache.org>
Subject [GitHub] nifi pull request: NiFI-1025: Imported aws-sdk:1.10.27 and joda-ti...
Date Wed, 04 Nov 2015 02:25:27 GMT
Github user trkurc commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/107#discussion_r43836211
  
    --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/TestPutS3Object.java
---
    @@ -87,16 +93,29 @@ public void testStorageClass() throws IOException {
         @Test
         public void testPermissions() throws IOException {
             final TestRunner runner = TestRunners.newTestRunner(new PutS3Object());
    -        runner.setProperty(PutS3Object.BUCKET, "test-bucket-00000000-0000-0000-0000-123456789012");
    +
             runner.setProperty(PutS3Object.CREDENTAILS_FILE, CREDENTIALS_FILE);
    -        runner.setProperty(PutS3Object.FULL_CONTROL_USER_LIST, "28545acd76c35c7e91f8409b95fd1aa0c0914bfa1ac60975d9f48bc3c5e090b5");
    +        runner.setProperty(PutS3Object.BUCKET, BUCKET_NAME);
    +        runner.setProperty(PutS3Object.FULL_CONTROL_USER_LIST,"28545acd76c35c7e91f8409b95fd1aa0c0914bfa1ac60975d9f48bc3c5e090b5");
    +        runner.setProperty(PutS3Object.REGION, REGION);
     
             final Map<String, String> attrs = new HashMap<>();
             attrs.put("filename", "folder/4.txt");
    -        runner.enqueue(Paths.get("src/test/resources/hello.txt"), attrs);
    +        runner.enqueue(getResourcePath(RESOURCE_NAME), attrs);
    +
             runner.run();
     
             runner.assertAllFlowFilesTransferred(PutS3Object.REL_SUCCESS, 1);
         }
     
    -}
    +    @Test
    +    /**
    +     * Run this test to check what version of Joda-time is actually being linked.
    +     *
    +     * @see: https://issues.apache.org/jira/browse/NIFI-1025
    +     * @see: https://github.com/aws/aws-sdk-java/issues/444
    +     */
    +    public void testJodaTime() {
    +        System.out.println(new DateTime().getClass().getProtectionDomain().getCodeSource());
    --- End diff --
    
    This doesn't appear to test for something - just a dump to the screen


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message