nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trkurc <...@git.apache.org>
Subject [GitHub] nifi pull request: NiFI-1025: Imported aws-sdk:1.10.27 and joda-ti...
Date Thu, 05 Nov 2015 01:47:45 GMT
Github user trkurc commented on the pull request:

    https://github.com/apache/nifi/pull/107#issuecomment-153927816
  
    In TestFetchS3Object.testSimpleGet(), the key, "folder/" is a bit confusing. I'm not intensely
familiar with the S3 java API, but I'm not sure how this fits with their "folder" concept
[1]. 
    
    ```
        public void testSimpleGet() throws IOException {
            String key = "folder/";
            uploadTestFile(key);
    ```
    
    Same issue with TestFetchS3Object.testTryToFetchNotExistingFile as TestDeleteS3Object.testTryToDeleteNotExistingFile.
I think this tests for a non-existent bucket, not file.
    
    [1] http://docs.aws.amazon.com/AmazonS3/latest/UG/FolderOperations.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message