nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trkurc <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1099 fixed the handling of InterruptedExce...
Date Fri, 06 Nov 2015 00:29:37 GMT
Github user trkurc commented on the pull request:

    https://github.com/apache/nifi/pull/115#issuecomment-154244035
  
    I started reviewing this. I'm not entirely sure blanket calling interrupt() is necessarily
the right approach. I think some of the InterruptedException swallowing may be legitimate
(e.g. the ShutdownHook). I think @markap14 wrote a decent part of RunNiFi and the Bootstrap
code, he may have thought of the potential side effects of swallowing those exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message