nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1099 fixed the handling of InterruptedExce...
Date Fri, 06 Nov 2015 14:00:09 GMT
Github user markap14 commented on the pull request:

    https://github.com/apache/nifi/pull/115#issuecomment-154416212
  
    @olegz : Thanks for the link! I've read the book, but it has been many years, probably
2-3 years out of college. I could probably learn from reading it again, now that I have a
much better understanding of Java and concurrency. Reading that article was certainly beneficial.
    
    That said, I think to @trkurc's point, in some of the locations (such as the bootstrap)
it may be okay to swallow and may not need to repeat the interrupt... There may also be places
that we should in fact being throwing InterruptedException ourselves.
    
    While I do agree that the Exception is not being handled properly, we should probably
review a little more closely rather than performing a blanket change to the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message