nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markap14 <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1000 Fixed JmsFactory to properly obtain d...
Date Tue, 10 Nov 2015 15:54:44 GMT
Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/118#discussion_r44422933
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
    @@ -152,7 +152,8 @@ language governing permissions and limitations under the License.
-->
             </dependency>
             <dependency>
                 <groupId>org.apache.activemq</groupId>
    -            <artifactId>activemq-client</artifactId>
    +            <artifactId>activemq-all</artifactId>
    +            <scope>test</scope>
    --- End diff --
    
    I agree we don't need the activemq-all at runtime, but I think we do need the activemq-client
at runtime, no? As-is here, we bring it all in for test and none of it at runtime.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message