nifi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From olegz <...@git.apache.org>
Subject [GitHub] nifi pull request: NIFI-1000 Fixed JmsFactory to properly obtain d...
Date Tue, 10 Nov 2015 15:58:32 GMT
Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/118#discussion_r44423561
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
    @@ -152,7 +152,8 @@ language governing permissions and limitations under the License.
-->
             </dependency>
             <dependency>
                 <groupId>org.apache.activemq</groupId>
    -            <artifactId>activemq-client</artifactId>
    +            <artifactId>activemq-all</artifactId>
    +            <scope>test</scope>
    --- End diff --
    
    No, we only need javax.jms at runtime. If we do need activeMq at runtime we are in big
trouble unless the intention of JmsFactory and all components around it was to work with ActiveMq
only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message